-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Publisher Edatalia Sign Online #3491
Update Publisher Edatalia Sign Online #3491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@microsoft-github-policy-service agree company="Axazure"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @marpedroche,
Why the image folder you kept it separate, and kindly let me know what is the purpose of keeping it separate and the purpose.
@vmanoharas This folder was in the previously validated branch. I updated the Publisher and replaced the logo with the new image. The 'img' folder is used to store the image used in the README file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @marpedroche
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.
[[certify-connector]] |
Hello @marpedroche, Separate img folder will stop uploading your files into our internal tools, as per the guidelines, Independent publisher should have only one folder, kindly include image also inside the main folder. |
@vmanoharas, I see that you approve the PR, please let me know if I have to change the images to the main folder. |
Yes @marpedroche, kindly update as requested as our automation tool will not run to upload artifacts into our internal tool. |
@vmanoharas update done! I removed all the folders and put the images in the mail folder. |
Your connector artifacts will not be uploaded into our internal tool, as Independent Publishers should not have any files other than apiDifinition.swagger.json, apiProperties.json and readme.md files. kindly submit only these files, and attach other files in the comments section, we will take care of during certification process. Apologies for the inconvenience caused, thank your patience and understanding. |
@vmanoharas these images you see are used in the readme file. |
Hello @marpedroche, Thank you very much for your quick response, however as per the process and the tool images are not allowed in the artifacts folder. In other words this is a blocker to proceed further. |
Hello @marpedroche, Kindly attach images here in the comments section and keep only three files (apiDifinition.swagger.json, apiProperties.json and readme.md). Our engineering team will take these images while processing your connector. |
@vmanoharas Please find the attached image. These items have already been removed from the repository. |
Hello @marpedroche, Please see the screenshot below, still we can see all the images which you deleted and added. Kindly close this PR and open a new PR with only three files mentioned above. |
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: