Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Publisher Edatalia Sign Online #3491

Closed

Conversation

marpedroche
Copy link
Contributor

@marpedroche marpedroche commented May 16, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@marpedroche marpedroche requested a review from a team as a code owner May 16, 2024 10:01
Copy link
Contributor Author

@marpedroche marpedroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@microsoft-github-policy-service agree company="Axazure"

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marpedroche,

Why the image folder you kept it separate, and kindly let me know what is the purpose of keeping it separate and the purpose.

image

@marpedroche
Copy link
Contributor Author

@vmanoharas This folder was in the previously validated branch. I updated the Publisher and replaced the logo with the new image. The 'img' folder is used to store the image used in the README file.

vmanoharas
vmanoharas previously approved these changes May 20, 2024
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marpedroche
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

@vmanoharas
Copy link
Contributor

[[certify-connector]]

@vmanoharas
Copy link
Contributor

Hello @marpedroche,

Separate img folder will stop uploading your files into our internal tools, as per the guidelines, Independent publisher should have only one folder, kindly include image also inside the main folder.

@marpedroche
Copy link
Contributor Author

@vmanoharas, I see that you approve the PR, please let me know if I have to change the images to the main folder.

@vmanoharas
Copy link
Contributor

@vmanoharas, I see that you approve the PR, please let me know if I have to change the images to the main folder.

Yes @marpedroche, kindly update as requested as our automation tool will not run to upload artifacts into our internal tool.

@marpedroche
Copy link
Contributor Author

@vmanoharas update done! I removed all the folders and put the images in the mail folder.

@vmanoharas
Copy link
Contributor

Your connector artifacts will not be uploaded into our internal tool, as Independent Publishers should not have any files other than apiDifinition.swagger.json, apiProperties.json and readme.md files. kindly submit only these files, and attach other files in the comments section, we will take care of during certification process.

Apologies for the inconvenience caused, thank your patience and understanding.

@marpedroche
Copy link
Contributor Author

@vmanoharas these images you see are used in the readme file.

@vmanoharas
Copy link
Contributor

@vmanoharas these images you see are used in the readme file.

Hello @marpedroche,

Thank you very much for your quick response, however as per the process and the tool images are not allowed in the artifacts folder. In other words this is a blocker to proceed further.

@vmanoharas
Copy link
Contributor

Hello @marpedroche,

Kindly attach images here in the comments section and keep only three files (apiDifinition.swagger.json, apiProperties.json and readme.md). Our engineering team will take these images while processing your connector.

@marpedroche
Copy link
Contributor Author

marpedroche commented Sep 6, 2024

@vmanoharas Please find the attached image. These items have already been removed from the repository.

APIKey
AxazureLogo
Connexion
integrationAPI
WebhookUrl

@vmanoharas
Copy link
Contributor

Hello @marpedroche,

Please see the screenshot below, still we can see all the images which you deleted and added. Kindly close this PR and open a new PR with only three files mentioned above.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants