Skip to content

Commit

Permalink
Merged PR 229897: Remove karma-coverage dependency
Browse files Browse the repository at this point in the history
Remove karma-coverage dependency because it causes build pipeline to fail and doesn't add enough value.

![ss.png](https://powerbi.visualstudio.com/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/1dd63332-e003-46a3-ac6f-70213a1bcc2e/pullRequests/229897/attachments/ss.png)
  • Loading branch information
Shahak Yosef committed Jan 12, 2022
1 parent ca1f6ae commit e7e8ed9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
10 changes: 1 addition & 9 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = function (config) {
{ pattern: './test/**/*.html', served: true, included: false }
],
exclude: [],
reporters: argv.chrome ? ['coverage', 'kjhtml'] : ['spec', 'coverage', 'junit'],
reporters: argv.chrome ? ['kjhtml'] : ['spec', 'junit'],
autoWatch: true,
browsers: [browserName],
browserNoActivityTimeout: 300000,
Expand All @@ -33,7 +33,6 @@ module.exports = function (config) {
'karma-jasmine',
'karma-spec-reporter',
'karma-phantomjs-launcher',
'karma-coverage',
'karma-jasmine-html-reporter',
'karma-junit-reporter'
],
Expand All @@ -43,13 +42,6 @@ module.exports = function (config) {
flags: flags.concat("--no-sandbox", "--window-size=800,800"),
},
},
preprocessors: { './tmp/**/*.js': ['coverage'] },
coverageReporter: {
reporters: [
{ type: 'html' },
{ type: 'text-summary' }
]
},
junitReporter: {
outputDir: 'tmp',
outputFile: 'testresults.xml',
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
"json-loader": "^0.5.4",
"karma": "6.3.5",
"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^2.0.3",
"karma-firefox-launcher": "^1.2.0",
"karma-jasmine": "4.0.1",
"karma-jasmine-html-reporter": "1.7.0",
Expand Down

0 comments on commit e7e8ed9

Please sign in to comment.