Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DataSources schema to add ConnectorId and update the schema definition. #716

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

jamevaalet
Copy link
Contributor

ConnectorId will be an optional property to differentiate between different types of connectors and will have default value as "Dataverse" if not supplied.

Solution

What are we doing to solve this issue?

Changes

  • Added optional ConnectorId property to DataSource Instance OM
  • Updated tests to reflect this change
  • Updated the yaml schema definition to reflect this change.

Validation

  • local testing

@jamevaalet jamevaalet requested review from a team as code owners September 13, 2024 19:56
src/schemas/pa-yaml/v3.0/pa.schema.yaml Outdated Show resolved Hide resolved
src/schemas/pa-yaml/v3.0/pa.schema.yaml Outdated Show resolved Hide resolved
src/schemas/pa-yaml/v3.0/pa.schema.yaml Show resolved Hide resolved
schemas/pa-yaml/v3.0/pa.schema.yaml Outdated Show resolved Hide resolved
schemas/pa-yaml/v3.0/pa.schema.yaml Show resolved Hide resolved
@jamevaalet jamevaalet closed this Sep 13, 2024
@jamevaalet jamevaalet reopened this Sep 13, 2024
@jamevaalet jamevaalet enabled auto-merge (squash) September 13, 2024 23:59
@jamevaalet jamevaalet merged commit 4495de9 into master Sep 16, 2024
4 checks passed
@jamevaalet jamevaalet deleted the users/jamevaa/DatasourcesYamlv3Schema branch September 16, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants