PaYaml V3 updates #679
Merged
PaYaml V3 updates #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehcrashxor
approved these changes
Jun 25, 2024
swapnilbhalgat
approved these changes
Jun 25, 2024
- `PaYamlSerializationContext` now holds the `PaYamlSerializerOptions` options instance, and moved YamlDotNet builder configs to this class. This helps to reduce the number of parameters needed for some custom converter operations, along with keeping the options class more like a POCO. - Used primary ctor in some locations - PaYaml OM properties for collection properties (`Properties`, `Children`, `Groups`) are now nullable, default to null, to conserve memory all around. - Reverted type name changes so the term `PaYaml` is preferred over just `Yaml`. As was already discussed as part of original changes, this term is used to differentiate the types from more general purpose Yaml serialization types.
joem-msft
force-pushed
the
users/joemay/PaYamlV3-updates-and-fixes
branch
from
197999d
to
d922d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScreenInstance.VariantPaYamlSerializationContextnow holds thePaYamlSerializerOptionsoptions instance, and moved YamlDotNet builder configs to this class. This helps to reduce the number of parameters needed for some custom converter operations, along with keeping the options class more like a POCO.Properties,Children,Groups) are now nullable, default to null, to conserve memory all around.PaYamlis preferred over justYaml. As was already discussed as part of original changes, this term is used to differentiate the types from more general purpose Yaml serialization types.