Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analysis info to header for yaml, fix missing template information in packed .msapp #495

Closed
wants to merge 1 commit into from

Conversation

jack-work
Copy link
Contributor

@jack-work jack-work commented Sep 14, 2023

Fixes this bug present due to newly introduced .msapp properties.
image

@jack-work jack-work requested a review from a team as a code owner September 14, 2023 02:50
@jack-work jack-work force-pushed the jack/bug-fixes branch 2 times, most recently from 397a426 to a2434a7 Compare September 14, 2023 03:04
@jack-work
Copy link
Contributor Author

This should be covered by json extension data in this class. A strong type should not be necessary

Copy link
Collaborator

@jt000 jt000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please abandon, this issue was previously fixed in 941f06c in a similar way that was mentioned in your comments. Please let me know if you're still able to repro after pulling this commit.

@petrochuk petrochuk closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants