Return appropriate derived class when method returns self #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 9, 2018 15:48
zooba
reviewed
Aug 10, 2018
| return _method.ReturnTypes.GetInstanceType(); | ||
| // Check if method returns self | ||
| var returnType = _method.ReturnTypes.GetInstanceType(); | ||
| if (args.Length > 0 && returnType.FirstOrDefault() is BuiltinInstanceInfo biif && biif.PythonType == _method.Function?.DeclaringType) { |
There was a problem hiding this comment.
There's a .Split extension method for returnType here that makes it easier to handle multiple return values properly (split with a predicate, then union and return). Otherwise, I like the approach
MikhailArkhipov
changed the title
zooba
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Looks good to me. Worth bearing in mind that when we decide to support all parameter mappings through return values for the single-pass analysis that this change will be largely undone. It may also miss some current cases or lose some information if there are multiple return types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4614
Will add test next