Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AstTypeStubPaths_* test failures #4509

Closed
huguesv opened this issue Jul 10, 2018 · 1 comment · Fixed by #4514
Closed

AstTypeStubPaths_* test failures #4509

huguesv opened this issue Jul 10, 2018 · 1 comment · Fixed by #4514
Assignees
@zooba
Labels
bug

Comments

@huguesv
Copy link
Contributor

huguesv commented Jul 10, 2018 •
edited
Loading 

AstTypeStubPaths_MergeStubsPath
AstTypeStubPaths_NoStubs
AstTypeStubPaths_MergeStubsPath
AstTypeStubPaths_ExclusiveStubs

They all fail like this:

System.AggregateException: One or more errors occurred. ---> Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException: Assert.Fail failed. Failed to get module we just imported
@huguesv huguesv added the Tests label Jul 10, 2018
@zooba zooba self-assigned this Jul 10, 2018
@zooba
Copy link
Member

zooba commented Jul 10, 2018

This is not just tests - some imports are actually broken.

zooba added a commit to zooba/PTVS that referenced this issue Jul 10, 2018
@zooba
Fixes microsoft#4509 Nested imports not resolving correctly
b52a2ec 
Corrects assigning submodules to analysis objects
Fixes references to unresolved module names
Fixes comparison of builtin functions
@zooba zooba mentioned this issue Jul 10, 2018
Merged
zooba added a commit that referenced this issue Jul 10, 2018
@zooba
Merge pull request #4514 from zooba/issue-4509
7666cea 
Fixes #4509 Nested imports not resolving correctly
zooba added a commit to zooba/PTVS that referenced this issue Jul 10, 2018
@zooba
Fixes microsoft#4509 Nested imports not resolving correctly
cff06db 
Corrects assigning submodules to analysis objects
Fixes references to unresolved module names
Fixes comparison of builtin functions
@zooba zooba mentioned this issue Jul 10, 2018
Merged
zooba added a commit that referenced this issue Jul 12, 2018
@zooba
Merge pull request #4524 from zooba/4509-15.8
94512b5 
[15.8] Fixes #4509 Nested imports not resolving correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4509 Nested imports not resolving correctly zooba/PTVS
2 participants
@zooba @huguesv