-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Directory.Build.props with newer version of packages for .NET 8 and 7 build #2272
Conversation
Hi @seesharprun, can you merge the latest from |
Done |
Thanks @seesharprun @pauld-msft The author has updated this PR, can you help take over this PR and help merge this if it looks good? Thanks! // cc @william-msft |
@samruddhikhandale @seesharprun Thanks. Confirmed that I can now kick off the validation / nightly pipelines. Depending on the pipeline fix, may need to perform the merge one more time to pull in those changes. This should help us confirm that we don't run into any separate issues with the pipelines |
@pauld-msft @william-msft Wondering if we have any updates on this one ^, thanks! |
@seesharprun mind doing the same thing, again? Thanks! Looks like the Oryx pipelines are now working. |
Done |
kicked off the tests again, thanks for following up |
Thank you @pauld-msft, let us know if it's ready to be merged. |
TLDR: Can't build Oryx in a devcontainer with .NET 7 and .NET 8 installed side-by-side
Bug Report
I'm attempting to update the devcontainers/images universal image to support .NET 8, but it's running into an issue where Oryx will not build (
dotnet build oryx.sln
) if a new version of .NET is installed.Even in an isolated environment with .NET 7 and .NET 8, building Oryx runs into the following error:
I was able to reproduce this issue in a blank GitHub codespace, on my local machine (with .NET 6, 7, and 8) and as part of the smoke test build for Oryx in the devcontainer/images repo.
Solution
I'm able to unblock this by changing the Directory.Build.props file to use a newer version of the
Microsoft.CodeAnalysis.NetAnalyzers
,Microsoft.CodeAnalysis.Compilers
, andMicrosoft.Net.Compilers.Toolset
packages.This PR updates the project to use newer versions of the package so you can build Oryx in an environment with just .NET 7 or in an environment with both .NET 7 and .NET 8.
Related
This resolves: