-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization: The running instance does not need to absorbed. #56
Comments
- Integrated #[from] attribute in `SuperNovaError` for efficient use of `NovaError`. - Consolidated call sites to use the conversion.
Hi @srinathsetty, can I work on this issue ? My understanding is that since u.x[0] = Hash(params, U, i, z0, zi) and we are absorbing Lines 240 to 241 in 48065b0
Similarly in NIFS::prove and NIFS::verify, we can avoid absorbing the RelaxedR1CSInstance Line 49 in 48065b0
Line 95 in 48065b0
We will have to update the const Let me know if this is fine. I can create a PR. |
@varunthakore Yes, that sounds great! |
Given that the public IO of the incoming R1CS instance contains the hash of the running instance in addition to (params, U, i, z0, zi), we can skip absorbing the running instance.
The text was updated successfully, but these errors were encountered: