This repository was archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Handles the empty string encoding/decoding in Python 2.7 #362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e51a64b.
Member
ganik
reviewed
Nov 13, 2019
Contributor
Author
|
The check() method in this context is: According to the Boost docs here, I believe this functions checks whether the given object can be converted to a given C# type, which in this case would be <const char*>. This check is necessary to properly handle a given text from Python to C++, and later to C#. |
This reverts commit 192337b.
…ted assertion value in corresponding unittest
Contributor
Author
|
As of commit d9b9544, the Mac Py2.7 build passes. |
Contributor
Author
|
Closing this PR for now as we are temporarily disabling the corresponding tests for the Mac Python 2.7 builds with PR #391 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix to Issue #360
Fixes #366
Handles the case where, with Python 2.7, string s is valid with utf_8 encoding, but is the empty string. I discovered the need for this fix as 2 test cases that were skipped before PR #359 were failing even with PR #359, due to this case with the empty string on Python 2.7.
These tests were:
EDIT: My observation on the error provided in TestLightGbmClassifier.test_lightgbmclassifier() was incorrect. The error is only visible in TestNGramFeaturizer.test_ngramfeaturizer(). The exact failure is here and here, shown on the Mac 2.7 build.