Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Fixed building of NimbusML with Python 3.5 on Windows (and other versions of Python) #297

Merged
ganik merged 11 commits into from
Oct 5, 2019
Merged

Fixed building of NimbusML with Python 3.5 on Windows (and other versions of Python) #297

Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
710fba5
Update Schema.py to remove the non-ASCII character
mstfbl Oct 1, 2019
820270c
Update build.cmd
mstfbl Oct 3, 2019
7b357a4
Update build.cmd
mstfbl Oct 3, 2019
0d3b65b
Merge branch 'master' of https://github.com/mstfbl/NimbusML
mstfbl Oct 3, 2019
9c3db19
Merge branch 'master' into master
mstfbl Oct 3, 2019
99018d5
Merge branch 'master' into master
mstfbl Oct 4, 2019
cb79b9d
Update build.cmd
mstfbl Oct 4, 2019
0124e68
Revert "Update build.cmd"
mstfbl Oct 4, 2019
1e703fa
Upgreate pip for all Python versions
mstfbl Oct 4, 2019
ea47529
Merge branch 'master' into master
mstfbl Oct 4, 2019
54a5df7
Merge branch 'master' into master
ganik Oct 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ if "%InstallPythonPackages%" == "True" (
:: Run azureml-dataprep tests only in pyhon 3.7 as its an optional dependency
if %PythonVersion% == 3.7 ( call "%PythonExe%" -m pip install --upgrade "azureml-dataprep>=1.1.12" )
call "%PythonExe%" -m pip install --upgrade "%__currentScriptDir%target\%WheelFile%"
if %PythonVersion% == 3.5 ( call "%PythonExe%" -m pip install --upgrade pip )

@najeeb-kazmi najeeb-kazmi Oct 3, 2019 •
edited by mstfbl
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the error installing scikit on Windows Py27 as well in my PR CI checks. Is anyone else seeing this as well?

If so, should we add this to line 351 instead? #Resolved

@ganik ganik Oct 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, could u pls work with Mustafa and show him the repro

In reply to: 331269871 [](ancestors = 331269871)

@pieths pieths Oct 4, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had the issue this morning trying to create a Python 3.6 release build. Maybe this should be added for all python versions?

In reply to: 331608183 [](ancestors = 331608183,331269871)

call "%PythonExe%" -m pip install "scikit-learn==0.19.2"
)

Expand Down