Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various quick CI fixups #870

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Oct 14, 2024

Pull Request

Title

Quick fixups to the documentation build.


Description

  • Expands one of the ignored warnings.
  • Reformats the sphinx conf for black and pylint.
  • Removes a warning from that file around redefinition of html_theme_path.
  • Adds a dependency requirement tweak for pyparsing when installing under python 3.8 (unrelated other CI bug).
  • Adds a workaround to a mypy false positive with in checking np.e as a "deleted variable" (e.g., e is used in a try/except block)

Type of Change

  • 🛠️ Bug fix
  • 📝 Documentation update

Testing

  • Ran make doc and make check-doc.
  • Ran make notebook-exec-test.

Additional Notes (optional)

This is a quick fix to get the CI pipeline working again.
The more complete fix to remove warning ignores from doc generation, improve cross reference linking, etc. will be handled later in #869


@bpkroth bpkroth requested a review from a team as a code owner October 14, 2024 20:05
@bpkroth bpkroth requested a review from motus October 14, 2024 20:06
Makefile Show resolved Hide resolved
@bpkroth bpkroth changed the title Quick doc build ci fixups Various quick CI fixups Oct 14, 2024
@bpkroth bpkroth merged commit 610341c into microsoft:main Oct 14, 2024
12 of 13 checks passed
@bpkroth bpkroth deleted the quick-doc-build-ci-fixups branch October 14, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants