-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci]: Bump actions/checkout from 1 to 4 in the ci-dependencies group #6453
[ci]: Bump actions/checkout from 1 to 4 in the ci-dependencies group #6453
Conversation
Bumps the ci-dependencies group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 1 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v1...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: ci-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Was just about to post this over on #6438 ... A bunch of these are failing because we test older versions of things in old container images that have old GLIBC ... and GitHub Actions is pushing all actions to use Node 20+ which requires at least GLIBC 2.28.
I don't want to give up our test coverage on older systems just to update a GitHub Action that runs |
Not that I know of :/ afaik, you can only instruct dependabot to skip versions (across all files)... |
hmmmm ok I'm not sure how we resolve this. Many GitHub Actions are raising these node16-to-node20 warnings and it's a system-level thing GitHub is pushing for.... but there are still not-end-of-life-yet systems with Some relevant links:
Given that, I think we should ignore this for now, like this: [at]dependabot ignore actions/checkout 4 |
I thought about this some more.... most of these changes will actually work! There are only 2 of them that can't automatically be applied:
I just pushed c58b5ab manually reverting dependabot's changes to those. I think that'll allow CI to pass here and then we can merge most of these changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me @jameslamb, let's proceed with some of the updates at least 😄
Bumps the ci-dependencies group with 1 update: actions/checkout.
Updates
actions/checkout
from 1 to 4Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
0ad4b8f
Prep Release v4.1.4 (#1704)43045ae
Disableextensions.worktreeConfig
when disablingsparse-checkout
(#1692)37b0821
Bump the minor-actions-dependencies group with 2 updates (#1693)9839dc1
Add dependabot config (#1688)9b4c13b
Bump word-wrap from 1.2.3 to 1.2.5 (#1643)1d96c77
Add SSH user parameter (#1685)cd7d8d6
Check git version before attempting to disablesparse-checkout
(#1656)8410ad0
Updateactions/checkout
version inupdate-main-version.yml
(#1650)9bb5618
Prep for release of v4.1.2 (#1649)8eb1f6a
Bump@babel/traverse
from 7.20.5 to 7.24.0 (#1642)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions