[python-package] take shallow copy of dataframe in predict (fixes #6195) #6218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoralez
requested review from
guolinke,
jameslamb and
shiyu1994
as code owners
|
Haha no worries. I missed it too when reviewing, the predict path wasn't clear (feature_name='auto' leading to the shallow copy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes a shallow copy of the dataframe in the
_data_from_pandasfunction to avoid modifying it when converting categorical features to their codes. This used to always be done (implicitly) for predict until #6066, since the function is called withfeature_name='auto'and thecopyargument ofpandas.DataFrame.renameis passed as thedeepargument topandas.DataFrame.copy, however that behavior wasn't obvious.Fixes #6195.
Also updates the test that verifies the original dataframe isn't modified to now consider the case of unseen categories, which fails in the current master and should prevent #6195 from happening again.