Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][dask][gpu] Run Dask tests with LightGBM GPU version #5292

Merged
merged 5 commits into from
Jan 3, 2023

Conversation

jgiannuzzi
Copy link
Contributor

As it was suggested in #5282 (comment) (previous attempt: #5285).

Using findings from #5282 (comment):

My understanding is that the dask tests only fail with this error on Ubuntu 14.04 with Python 3.10. I ran them locally with Python 3.8 and 3.9 and they work fine. Do we maybe want to set PYTHON_VERSION again on the Linux gpu_source job?

On Ubuntu 20.04, the tests seem to fail because of a timeout. Enabling those tests on a fake GPU is expected to take more time. Maybe setting timeoutInMinutes like we do for the aarch64 job would help?

@jameslamb
Copy link
Collaborator

@jgiannuzzi I just updated this branch with the changes from latest master. I'm hoping that these changes that have accumulated since this PR was first opened will allow us to re-enable the Dask tests for gpu builds:

Thanks for experimenting with this and pushing it forward! The Dask tests are the most comprehensive tests on distributed training that this project has, so enabling them on more environment and installation types is really valuable to the project.

@jameslamb jameslamb marked this pull request as ready for review January 2, 2023 23:35
.vsts-ci.yml Outdated Show resolved Hide resolved
.vsts-ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to say that this is working!

I think that the timeout observed was actually not about the tests taking too long to run, but was related some combination of:

Given that, I pushed 06c2d3b removing the proposed timeouts for Azure DevOps from this PR.

The GPU jobs are taking less than 30 mins (build link).

Screen Shot 2023-01-02 at 7 38 28 PM

Thanks very much for improving the test coverage @jgiannuzzi !

@jameslamb jameslamb changed the title [dask][gpu] Run Dask tests with LightGBM GPU version [ci][dask][gpu] Run Dask tests with LightGBM GPU version Jan 3, 2023
@jameslamb jameslamb merged commit de10d0d into microsoft:master Jan 3, 2023
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
@jgiannuzzi jgiannuzzi deleted the dask branch August 16, 2023 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants