Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup codeowners #5215

Merged
merged 5 commits into from
May 18, 2022
Merged

Cleanup codeowners #5215

merged 5 commits into from
May 18, 2022

Conversation

StrikerRUS
Copy link
Collaborator

Remove inactive persons from the CODEOWNERS file.

Removed persons have been inactive for a long time (or simply never reviewed any PR) and unlikely will return to review new PRs.
CODEOWNERS file is used to automatically assign reviewers for PRs. Keeping this file clean and actual might be important for two reasons:

  • outside contributors will be more patient for long delays in reviews when they understand the actual number of persons who are able to give a review;
  • active maintainers will be more motivated to provide their reviews and feel greater responsibility for in time replies when they see only a couple of persons among assigned reviewers for a particular PR or that there is no "backup" reviewer for that code changes at all.

However, active maintainers can still ping these removed from the file persons manually in special cases according to this "person - code area" mapping.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree, thank you very much for doing this!

@StrikerRUS StrikerRUS merged commit 7d89ab4 into master May 18, 2022
@StrikerRUS StrikerRUS deleted the cleanup_codeowners branch May 18, 2022 23:14
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants