Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially resolve [CLI] Categorical: Read string and convert to int on the fly #789 (closed in favour #2303) #4658

Closed
wants to merge 3 commits into from

Conversation

Dinara301
Copy link

Hi team!
I extensively used create_tree_digraph function and found that there is no way to show categorical features values as they were initially before the internal encoding. It seems that there should be a possibility to decode these categorical variables to be displayed with their initial values in graph.
I've found issue #789 connected to this problem. It's also included in #2302 feature requests issue.

For now it's only fixed for the "create_tree_digraph" function with decode_categorical as optional parameter set by default to False.

Please let me know if this is reasonable feature and fix.

@ghost
Copy link

ghost commented Oct 8, 2021

CLA assistant check
All CLA requirements met.

@jameslamb
Copy link
Collaborator

Thanks very much for the idea and pull request, @Dinara301 .

Before we consider this, can you please sign the CLA (#4658 (comment))? Please let us know if you have any questions or concerns.

@Dinara301
Copy link
Author

Thanks very much for the idea and pull request, @Dinara301 .

Before we consider this, can you please sign the CLA (#4658 (comment))? Please let us know if you have any questions or concerns.

@jameslamb Thank you, I've signed CLA.

@Dinara301
Copy link
Author

Thanks very much for the idea and pull request, @Dinara301 .

Before we consider this, can you please sign the CLA (#4658 (comment))? Please let us know if you have any questions or concerns.

Hi! Could you please take a look into PR I've fixed pep8 issue so checks are passed successfully now. Also I think that it might be better to add test with directly marking categorical features and not "auto" approach. What do you think?

@jameslamb
Copy link
Collaborator

Sorry for the VERY long delay @Dinara301 ! We apologize for taking so long to respond to you. I'm here to help move this forward and answer any questions you have.

Are you still interested in pursuing this feature? If so, please do the following:

  1. merge the latest changes from master into this branch
  2. please provide a small, self-contained reproducible example that we could run which demonstrates this behavior.
  3. please provide at least one screenshot showing what the plots will look like as of these changes

Thanks for helping to improve LightGBM!

@jameslamb
Copy link
Collaborator

I'm going to close this PR due to lack of activity.

@Dinara301 if you decide in the future that you'd like to pursue this idea, please open a new pull request. Thanks for your interest in LightGBM.

Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants