-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add link to Neptune hyperparam tuning guide #4529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much! Looks like an interesting tool and we really appreciate the effort you've put in so far on supporting LightGBM.
NOTE: I changed the title of this pull request to be more descriptive of the change. I did this because PR titles become changelog entries in LightGBM releases (e.g. see https://github.com/microsoft/LightGBM/releases/tag/v3.2.1), but in general I think you'll find that open source projects would prefer that your PR titles be descriptive and not just branch names.
I read through https://neptune.ai/blog/lightgbm-parameters-guide and have a few minor notes I'd like you to consider (not necessary for merging this PR though!).
- https://github.com/huanzhang12/lightgbm-gpu is not actively maintained and has not been updated in 4+ years, so it can't be relied on as an accurate documentation of the current state of LightGBM. You might @szilard and @Laurae2 's work in https://github.com/szilard/GBM-perf a more accurate benchmark of LightGBM's performance with different settings and hardware.
- remove code samples that use filepaths specific to a one person's local filesystem, like
neptune.init('mjbahmani/LightGBM-hyperparameters')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake, meant to leave a "request changes" review until the suggestion about the link text is accepted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to decide whether we accept commercial products here while being FOSS project.
@jameslamb
True, that's a good point I hadn't considered. I wasn't thinking about it because this section of the documentation is just a list of links and I didn't really see it as an endorsement, but I didn't consider the precedent it might set. That said, I'm personally ok with this PR that is just adding a link to documentation. If someone from AWS or GCP or Azure came here tomorrow and wanted to add a link to a blog post with this level of depth about LightGBM, I'd be ok with that too. If it was just "here is the marketing material about our product and we added LightGBM in a bullet point about supported frameworks", I'd say that isn't something we should accept. As long as we're not endorsing anything and not implying any sort of affiliation with commercial products, it doesn't bother me. |
@jameslamb
This PR actually proposes adding two links. |
Ah! Completely an oversight on my part, I didn't notice the other link under "External Repositories". I don't think anything about this or other commercial products should be added to the "External (Unofficial) Repositories" section. |
Co-authored-by: James Lamb <[email protected]>
Thank you for the advice I have requested an update for the links. When it comes to the second point, there is no worry because that is particular to the hosted Neptune account, not his local filesystem, therefore only he has access to that workspace and project. |
Start off by apologising I didn't necessarily know where to place the integration link that's why I asked in the first message. Now, I understand it might feel like it's just marketing and LightGBM is just a line. But we wanted to do more and I think we did more and than just support LightGBM. As I mention in the PR message, I was asking to know if there is a space in your docs that you dedicated to such tools? (i.e. loggers page). Because today more than ever ML practitioners are in need of metadata store(data versioning, experiment tracking and model registry), especially for research and production teams that run tens, hundreds or thousands of experiments a day. |
Done ✅ |
@jameslamb Agree! I believe one link to params tuning guide with Neptune will be enough. |
Ok great. @Blaizzy thanks for your patience as we work through this, this isn't a topic that maintainers here have talked about in-depth recently. For this PR, please remove the link you've added in
If you're interested in continuing the discussion about having a space in LightGBM's documentation which explicitly lists commercial products with LightGBM integrations, please open an issue at https://github.com/microsoft/LightGBM/issues which describes why you think this project should do that, including links to the specific examples you've referenced here. |
Thank you very much @jameslamb @StrikerRUS, I understand and will make the necessary changes! |
Done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Hi,
I'm Prince Canuma a Data Scientist and DevRel at Neptune.ai,
We have created a Neptune + LightGBM integration that allows LightGBM users to automatically log the following metadata to Neptune:
We are looking for ways to let users of LightGBM know this integration exists, is available and is up to date. To ensure the latter, we want to collaborate with you in future versions of LightGBM.
Finally, besides the README are there other ways you would recommend divulging this information? If so, please let us know!
We want to let LightGBM users know about the Neptune + LightGBM integration.
Kind regards!