[ci][python] run isort in CI linting job #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Feb 16, 2021
Comment on lines
+12
to
+14
| line_length = 120 | ||
| skip = external_libs | ||
| known_first_party = lightgbm |
There was a problem hiding this comment.
isort respects .editorconfig: https://pycqa.github.io/isort/docs/configuration/config_files/#editorconfig
StrikerRUS
requested review from
chivee,
guolinke,
henry0312,
jameslamb,
Laurae2 and
wxchan
as code owners
jameslamb
approved these changes
Feb 16, 2021
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3958.
Closed #3983.
Some files have
isort-related diff althoughisorthas been already applied due to new120length limit in config file.Also prefer installation from conda to pip for
rstcheck.mypy,isortandpycodestylehave conflicts when installing fromcondaaltogether.