-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dask] Add unit tests that signatures are the same between Dask and scikit-learn estimators #3911
Conversation
bunch of syntax and styling mistakes, my bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! I like the way you set this up with pytest.mark.parametrize
. I left some suggestions for your consideration.
I've edited your pull request description to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please see my newest comments.
Now I understand why I was getting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Please see my newest suggestion
…cikit-learn estimators (fixes #3907)
…cikit-learn estimators (fixes #3907)
…cikit-learn estimators (fixes #3907)
…cikit-learn estimators (fixes #3907)
…cikit-learn estimators (fixes #3907)
…cikit-learn estimators (fixes #3907)
…cikit-learn estimators (fixes #3907)
…cikit-learn estimators (fixes #3907)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thanks very much for the contribution!
Thanks a lot for the guidance! |
I tried to check for a sublist in sklearn's args which matches dask's (this ensures that order is checked), the same goes for the
default values.
fixes #3907