-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] improve and run CUDA jobs for every commit and PR #3825
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
794baff
Update setup.sh
StrikerRUS 23521d8
Update cuda.yml
StrikerRUS ed84323
Update cuda.yml
StrikerRUS 4d5fcbd
Update README.md
StrikerRUS 67bfaf5
Update cuda.yml
StrikerRUS 4edb06d
Update cuda.yml
StrikerRUS 7907013
Update cuda.yml
StrikerRUS adde65d
Update setup.sh
StrikerRUS 142e542
Update setup.sh
StrikerRUS 6f72bc8
Update setup.sh
StrikerRUS 1648a22
Update cuda.yml
StrikerRUS 4b18bdc
Update cuda.yml
StrikerRUS 1261673
Update cuda.yml
StrikerRUS ef2a6f7
Update cuda.yml
StrikerRUS 4a478f2
Update cuda.yml
StrikerRUS 79fe666
Update cuda.yml
StrikerRUS a5b976d
Update cuda.yml
StrikerRUS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really glad to see building CMake from source replaced with an installation from a package manager 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I decided that it is enough to have the most recent CMake for our other Linux jobs run inside Ubuntu 14.04 container. Thanks to default CMake from apt-get in Ubuntu 20.04 is quite fresh and passes our minimum version check!
LightGBM/CMakeLists.txt
Lines 21 to 22 in ac706e1
As a bonus, we don't need to update it in one more place regularly 🙂