[python][tests] migrate test_engine.py to pytest #3800
Conversation
thomasjpfan
requested review from
chivee,
henry0312,
StrikerRUS and
wxchan
as code owners
jameslamb
changed the title
There was a problem hiding this comment.
Thanks so much for doing this! I compared with https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56, and found a few mistakes.
Also thank you for removing these extra unused metrics.
| verbose_eval=False, | ||
| evals_result=evals_result) | ||
| ret = multi_logloss(y_test, gbm.predict(X_test)) | ||
| assert ret < 6 |
There was a problem hiding this comment.
| assert ret < 6 | |
| assert ret < 0.16 |
from https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56
| verbose_eval=False, | ||
| evals_result=evals_result) | ||
| ret = multi_logloss(y_test, gbm.predict(X_test)) | ||
| assert ret < 3 |
There was a problem hiding this comment.
| assert ret < 3 | |
| assert ret < 0.23 |
from https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56
| "pred_early_stop_freq": 5, | ||
| "pred_early_stop_margin": 1.5} | ||
| ret = multi_logloss(y_test, gbm.predict(X_test, **pred_parameter)) | ||
| assert ret < 8 |
There was a problem hiding this comment.
| assert ret < 8 | |
| assert ret < 0.8 |
from https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56
| "pred_early_stop_freq": 5, | ||
| "pred_early_stop_margin": 5.5} | ||
| ret = multi_logloss(y_test, gbm.predict(X_test, **pred_parameter)) | ||
| assert ret < 2 |
There was a problem hiding this comment.
| assert ret < 2 | |
| assert ret < 0.2 |
from https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56
| evals_result=evals_result, | ||
| init_model=init_gbm) | ||
| ret = multi_logloss(y_test, gbm.predict(X_test)) | ||
| assert ret < 1 |
There was a problem hiding this comment.
| assert ret < 1 | |
| assert ret < 0.1 |
from https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56
| preds = cvb.predict(X_test) | ||
| avg_pred = np.mean(preds, axis=0) | ||
| ret = log_loss(y_test, avg_pred) | ||
| assert ret < 5 |
There was a problem hiding this comment.
| assert ret < 5 | |
| assert ret < 0.15 |
https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56
| # fold averaging | ||
| avg_pred = np.mean(preds, axis=0) | ||
| ret = log_loss(y_test, avg_pred) | ||
| assert ret < 3 |
There was a problem hiding this comment.
| assert ret < 3 | |
| assert ret < 0.13 |
from https://www.textcompare.org/index.html?id=6008e19c6d59840017ac7a56
| assert ret_origin == pytest.approx(ret) | ||
|
|
||
|
|
||
| @unittest.skipIf(not lgb.compat.PANDAS_INSTALLED, 'pandas is not installed') |
There was a problem hiding this comment.
could this and other unittest.skipIf in this PR use pytest.importorskip like you did in #3798 ? So that we don't need to import unittest
There was a problem hiding this comment.
@thomasjpfan Wow, you did it! So huge file! Thanks a lot for the help with it.
I've found only 3 typos, the rest looks just great!
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Towards #3732