Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] ignore R CMD CHECK warnings on new R version #3468

Merged
merged 2 commits into from
Oct 18, 2020
+4 −5
Merged

[ci] ignore R CMD CHECK warnings on new R version #3468

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba2923b
[ci] ignore R CMD CHECK warnings on new R version
jameslamb Oct 17, 2020
495b700
just update version
jameslamb Oct 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
just update version
@jameslamb
jameslamb committed Oct 18, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 495b70037a3ff2fe13c8b169b5263a1d244039d3
12 changes: 3 additions & 9 deletions .ci/test_r_package.sh
View file
Original file line number Diff line number Diff line change
@@ -18,8 +18,8 @@ if [[ "${R_MAJOR_VERSION}" == "3" ]]; then
export R_LINUX_VERSION="3.6.3-1bionic"
export R_APT_REPO="bionic-cran35/"
elif [[ "${R_MAJOR_VERSION}" == "4" ]]; then
export R_MAC_VERSION=4.0.2
export R_LINUX_VERSION="4.0.2-1.1804.0"
export R_MAC_VERSION=4.0.3
export R_LINUX_VERSION="4.0.3-1.1804.0"
export R_APT_REPO="bionic-cran40/"
else
echo "Unrecognized R version: ${R_VERSION}"
@@ -187,13 +187,7 @@ if [[ $check_succeeded == "no" ]]; then
exit -1
fi

num_warnings=$(
cat ${LOG_FILE_NAME} \
| grep -q -R "WARNING" \
| grep -v "was built under R version" \
| wc -l
)
if [[ ${num_warnings} -gt 0 ]]; then
if grep -q -R "WARNING" "$LOG_FILE_NAME"; then
echo "WARNINGS have been found by R CMD check!"
exit -1
fi
4 changes: 2 additions & 2 deletions .ci/test_r_package_windows.ps1
View file
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ if ($env:R_MAJOR_VERSION -eq "3") {
$RTOOLS_INSTALL_PATH = "C:\rtools40"
$env:RTOOLS_MINGW_BIN = "$RTOOLS_INSTALL_PATH/mingw64/bin"
$env:RTOOLS_EXE_FILE = "rtools40-x86_64.exe"
$env:R_WINDOWS_VERSION = "4.0.2"
$env:R_WINDOWS_VERSION = "4.0.3"
} else {
Write-Output "[ERROR] Unrecognized R version: $env:R_VERSION"
Check-Output $false
@@ -164,7 +164,7 @@ if ($env:COMPILER -ne "MSVC") {
echo "ERRORs have been found by R CMD check!"
Check-Output $False
}
if (Get-Content "$LOG_FILE_NAME" | Select-String -Pattern "WARNING" -CaseSensitive -Quiet | Select-String -Pattern "was built under R version" -NotMatch -CaseSensitive -Quiet) {
if (Get-Content "$LOG_FILE_NAME" | Select-String -Pattern "WARNING" -CaseSensitive -Quiet) {
echo "WARNINGS have been found by R CMD check!"
Check-Output $False
}