-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Add support for non-ASCII feature names #2983
Comments
Closed in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature. |
@StrikerRUS Even though Hacktoberfest is over, I still think that It's very common practice on GitHub for would-be new contributors to go to a repository and expect to be able to filter the open issues by |
@jameslamb I'm OK with that. But please add some words about that in #2302 opening message then. |
Summary
See #2976 for background. That PR adds support for non-ASCII features back to the C++ and Python libraries. A test in the R package was added in that PR but was breaking for reasons that weren't obvious, see for example #2976 (comment).
I think that closing this issue will mean changing
lgb.encode.char()
. You'll know that a f ix is working if you remove thetestthat::skip()
call added in #2976 .The text was updated successfully, but these errors were encountered: