Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] Standardize R code on comma-first #2373

Closed
jameslamb opened this issue Sep 2, 2019 · 3 comments
Closed

[R-package] Standardize R code on comma-first #2373

jameslamb opened this issue Sep 2, 2019 · 3 comments
Labels
good first issue help wanted r-package

Comments

@jameslamb
Copy link
Collaborator

Per this comment on #2334 . We should standardize all R code in the repo on comma-first.
@guolinke guolinke mentioned this issue Sep 16, 2019
Open
@StrikerRUS
Copy link
Collaborator

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 23, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
0fa21b9
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 23, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
fc3ef86
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 24, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
5a3dd6b
This was referenced Sep 24, 2019
Merged
Merged
@jameslamb
Copy link
Collaborator Author

reopening this issue as there is an active PR to fix it

@jameslamb jameslamb reopened this Sep 24, 2019
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 24, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
80f1fcd
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 24, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
cd2d123
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 29, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
e718c95
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 29, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
ab14596
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Sep 29, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
f2a9f00
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Oct 6, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
3651823
@jameslamb jameslamb changed the title [R] Standardize R code on comma-first [R-package] Standardize R code on comma-first Oct 6, 2019
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Oct 21, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
aaf7a83
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Oct 24, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
0d1918a
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Oct 24, 2019
@jameslamb
added R linting and changed R code to comma-first (fixes microsoft#2373)
37b294b
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue help wanted r-package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameslamb @StrikerRUS