fix a bug

microsoft · Jan 30, 2020 · 32f3f6f · 32f3f6f
1 parent ce8725d
commit 32f3f6f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/treelearner/serial_tree_learner.cpp b/src/treelearner/serial_tree_learner.cpp
@@ -404,7 +404,11 @@ void SerialTreeLearner::FindBestSplitsFromHistograms(const std::vector<int8_t>&
     smaller_node_used_features = GetUsedFeatures(false);
     larger_node_used_features = GetUsedFeatures(false);
   }
+  OMP_INIT_EX();
+  // find splits	
+  #pragma omp parallel for schedule(static)
   for (int feature_index = 0; feature_index < num_features_; ++feature_index) {
+    OMP_LOOP_EX_BEGIN();
     if (!is_feature_used[feature_index]) { continue; }
     const int tid = omp_get_thread_num();
     SplitInfo smaller_split;
@@ -451,8 +455,9 @@ void SerialTreeLearner::FindBestSplitsFromHistograms(const std::vector<int8_t>&
     if (larger_split > larger_best[tid] && larger_node_used_features[feature_index]) {
       larger_best[tid] = larger_split;
     }
+    OMP_LOOP_EX_END();
   }
-
+  OMP_THROW_EX();
   auto smaller_best_idx = ArrayArgs<SplitInfo>::ArgMax(smaller_best);
   int leaf = smaller_leaf_splits_->LeafIndex();
   best_split_per_leaf_[leaf] = smaller_best[smaller_best_idx];