-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused headers from gsl/pointers #1153
base: main
Are you sure you want to change the base?
Conversation
I just see that |
forward is already declared in utility, no need to include algorithm which is relativaly heavy hash is already declared in memory, no need to bring brand-new header system_error for hash only
7018630
to
138ac72
Compare
hi! Is there any chances too see a progress here? Can it get merged to the main? it seems useful changes in my opinion. |
@knst There appears to be a problem running checks on this PR. Can you push a dummy change as shown below to retrigger the tests.
|
138ac72
to
2445d84
Compare
I force pushed a branch, seems as I need approval again |
Hey all, this has been approved for a while? CI failures seem unrelated? Please advise, it'd be nice to get some movement again |
forward
is already declared in utility, no need to include<algorithm>
which is relatively heavyhash
is already declared in memory, no need to bring brand-new header<system_error>
for hash only.On my machine with my customized fork of GSL it improves a compilation time of gsl/pointers drastically.
See benchmark (best time over 5 runs):
Considering using
gsl/pointers
all over codebase it speeds up compilation time of any project that uses gsl/pointers.