Issue with Fluid Audience Service

[arafat-java]

Describe the bug

We are facing an intermittent issue where the Audience API returns single user with id as null/undefined
This usually happens will certain time when all the collaborators have left the sesssion
When we query the cache directly we do not get any users there.

To Reproduce

Steps to reproduce the behavior:
It is intermittent

1. Start a collaborative session
2. Add some more collaborators
3. Let all the collaborators leave
4. Connect to container to fetch the audience
5. You would get 1 user and id is null/undefined

Expected behavior

Ideally it should return zero users but if it still is returning 1 user for certain time then it should return with proper id

[jason-ha]

@arafat-java, what version of FluidFramework client are you using and which service (azure-client, odsp-client, or custom)?

[arafat-java]

We are presently using server_v5.0.0 and the issue is coming when using the azure-client
We intend to upgrade to server_v6.0.0 soon

[jason-ha]

@arafat-java, and what version of azure-client?

To make sure we are looking for the same bad result, you are saying that if you had code like:

	const audienceMembers = services.audience.getMembers();
	for (const [id, member] of audienceMembers.entries()) {
		console.log(`Member '${id}' is present with id '${member.id}'.`);
	}

the result would be:
Member 'null' is present with id 'null'
or maybe member is undefined?

[arafat-java]

It would be
Member 'undefined' is present with id 'undefined'.

[WillieHabi]

Hello, I'm attempting repro the issue here!

Ideally it should return zero users...

Why do you say you're expecting zero users in audience? When you say "4. Connect to container to fetch the audience", I assume you would expect 'self' to be in audience as well, right?

[arafat-java]

My bad, should have been explicit
Ideally I was expecting zero users apart from myself. But there is one and that is causing the 'undefined' issue

[WillieHabi]

Thanks for the detail. I contacted the server team and this issue should be fixed by upgrading to server_v6.0.0 (was addressed with this fix #20329).

Try upgrading to 6.0.0 and see if the issue persists.

[WillieHabi]

Hi @arafat-java ! Just want to follow up here to see if the server bump helped resolve the issue.

[arafat-java]

@WillieHabi We've faced certain roadblocks in server version upgrade. Should be done in a week or so. Will check and update here post that

[arafat-java]

@WillieHabi We updated our server to v6.0.0 but it is still the same. Getting the exact same error
Can you please check

[WillieHabi]

That's unfortunate to hear -- will be contacting the server team again and attempt to reproduce the issue against server v6.0.0.

[WillieHabi]

Can you say what version of Fluid client (azure-client) you are using?

And if possible could you provide code snippet of specific API that are returning audience members with undefined id's.

[arafat-java]

@fluidframework/azure-client "2.0.0-rc.1.0.9"

The code snippet is as follows

export function getCollaboratingUsersAzure(
  containerInfo: ContainerInfo,
  excludeUser?: string
): AzureMember[] {
  verifyConnectedState(containerInfo, "getCollaboratingUsersAzure");

  const services = containerInfo.services;
  if (!services) {
    return [];
  }

  const users: AzureMember[] = [];
  const members = services.audience.getMembers();
  members.forEach((member, key) => {
    if (!excludeUser || key !== excludeUser) {
      users.push(member);
    }
  });

  return users;
}