Make precedence source ordered - #623
Merged
Merged
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Zhiyuan Liang (zhiyuanliang-ms)
approved these changes
Sep 21, 2026
This was referenced Sep 24, 2026
Jagdish Kumawat (jagdish-kumawat)
added a commit
to Dewiride-Open-Source/ERP-AI-Pro
that referenced
this pull request
Sep 27, 2026
…der FeatureManagement 4.8.0 Microsoft.FeatureManagement 4.8.0 (microsoft/FeatureManagement-Dotnet#623) visits configuration sources from the highest precedence down and checks both schemas within each, so a later source wins whichever schema it uses; 4.7.0 consulted the Microsoft schema of every source first. The test that pinned the old order now proves the later source wins in both schema orders. AddErpConfiguration keeps forcing the Microsoft schema on the store, the schema every other source uses; its comment and docs/configuration.md now give that reason.
Jagdish Kumawat (jagdish-kumawat)
added a commit
to Dewiride-Open-Source/ERP-AI-Pro
that referenced
this pull request
Sep 27, 2026
* build(deps): Bump the microsoft group with 1 update Bumps Microsoft.FeatureManagement from 4.7.0 to 4.8.0 --- updated-dependencies: - dependency-name: Microsoft.FeatureManagement dependency-version: 4.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: microsoft ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): refresh the host lock files for Microsoft.FeatureManagement 4.8.0 Dependabot bumped the central pin in Directory.Packages.props but left the CentralTransitive entries of the three host lock files at 4.7.0, so every locked restore failed with NU1004. Regenerated with dotnet restore --force-evaluate. * test(platform): prove feature flag precedence follows source order under FeatureManagement 4.8.0 Microsoft.FeatureManagement 4.8.0 (microsoft/FeatureManagement-Dotnet#623) visits configuration sources from the highest precedence down and checks both schemas within each, so a later source wins whichever schema it uses; 4.7.0 consulted the Microsoft schema of every source first. The test that pinned the old order now proves the later source wins in both schema orders. AddErpConfiguration keeps forcing the Microsoft schema on the store, the schema every other source uses; its comment and docs/configuration.md now give that reason. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jagdish Kumawat <jagdish.kumawat@dewiride.com>
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
Fix #621
ConfigurationFeatureDefinitionProvideralways evaluates the Microsoft schema first, source order is never consulted when the same flag is split across schemas. A Microsoft-schema definition from the first provider beats a .NET-schema definition from every later provider.Visible Changes
Example
When custom merging is enabled:
Provider` 1: Microsoft schema → MyFlag = false
Provider 2: .NET schema → MyFlag = targeting filter
Winning schema map:
MyFlag → .NET
Result: Provider 2 wins and the targeting filter is parsed.