Skip to content

Fix IsEnabledAsync null context #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zhiyuan Liang (zhiyuanliang-ms) merged 3 commits into from
Aug 26, 2026
Merged

Fix IsEnabledAsync null context #612

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22d142a
fix isenabled null context bug
zhiyuanliang-ms Aug 16, 2026
3533796
update
zhiyuanliang-ms Aug 19, 2026
6e2023a
Merge branch 'main' into zhiyuanliang/fix-isenabled-nre
zhiyuanliang-ms Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Microsoft.FeatureManagement/FeatureManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ public async Task<bool> IsEnabledAsync(string feature)
/// <returns>True if the feature is enabled, otherwise false.</returns>
public async Task<bool> IsEnabledAsync<TContext>(string feature, TContext appContext)
{
if (appContext is null)
{
throw new ArgumentNullException(nameof(appContext));
}

return (await EvaluateFeature(feature, context: appContext, useContext: true, CancellationToken.None).ConfigureAwait(false)).Enabled;
}

Expand All @@ -178,6 +183,11 @@ public async ValueTask<bool> IsEnabledAsync(string feature, CancellationToken ca
/// <returns>True if the feature is enabled, otherwise false.</returns>
public async ValueTask<bool> IsEnabledAsync<TContext>(string feature, TContext appContext, CancellationToken cancellationToken = default)
{
if (appContext is null)
Comment thread
zhiyuanliang-ms marked this conversation as resolved.
Resolved
{
throw new ArgumentNullException(nameof(appContext));
}

return (await EvaluateFeature(feature, context: appContext, useContext: true, cancellationToken).ConfigureAwait(false)).Enabled;
}

Expand Down
Loading