Skip to content

Add testcases for time window filter cache entry #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhiyuanliang-ms merged 7 commits into from
Dec 17, 2024
+187 −63
Merged

Add testcases for time window filter cache entry #445

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b462a53
add test for time window filter cache entry
zhiyuanliang-ms May 8, 2024
6e4dc98
check there is no cache entry before evaluation
zhiyuanliang-ms May 8, 2024
c3f4a7f
track the count of timewindow calculation
zhiyuanliang-ms May 9, 2024
5da2d7d
use customized IMemoryCache
zhiyuanliang-ms Jun 19, 2024
45310b5
Merge branch 'main' of https://github.com/microsoft/FeatureManagement…
zhiyuanliang-ms Jun 19, 2024
9d9918a
resolve merge conflict
zhiyuanliang-ms Aug 16, 2024
08a2712
merge main
zhiyuanliang-ms Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tests/Tests.FeatureManagement/FeatureManagement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,11 +343,7 @@ public async Task TimeWindow()
Assert.False(await featureManager.IsEnabledAsync(feature4));
Assert.True(await featureManager.IsEnabledAsync(feature5));
Assert.False(await featureManager.IsEnabledAsync(feature6));

for (int i = 0; i < 10; i++)
{
Assert.True(await featureManager.IsEnabledAsync(Features.RecurringTimeWindowTestFeature));
}
Assert.True(await featureManager.IsEnabledAsync(Features.RecurringTimeWindowTestFeature));
}

[Fact]
Expand Down
112 changes: 79 additions & 33 deletions tests/Tests.FeatureManagement/RecurrenceEvaluation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,122 +1618,168 @@ public async void RecurrenceEvaluationThroughCacheTest()
{
OnDemandClock mockedTimeProvider = new OnDemandClock();

IMemoryCache cache = new MemoryCache(new MemoryCacheOptions());

var mockedTimeWindowFilter = new TimeWindowFilter()
{
Cache = new MemoryCache(new MemoryCacheOptions()),
Cache = cache,
SystemClock = mockedTimeProvider
};

var context = new FeatureFilterEvaluationContext()
TimeWindowFilterSettings settings = new TimeWindowFilterSettings()
{
Settings = new TimeWindowFilterSettings()
Start = DateTimeOffset.Parse("2024-2-1T00:00:00+08:00"), // Thursday
End = DateTimeOffset.Parse("2024-2-1T12:00:00+08:00"),
Recurrence = new Recurrence()
{
Start = DateTimeOffset.Parse("2024-2-1T00:00:00+08:00"), // Thursday
End = DateTimeOffset.Parse("2024-2-1T12:00:00+08:00"),
Recurrence = new Recurrence()
Pattern = new RecurrencePattern()
{
Pattern = new RecurrencePattern()
{
Type = RecurrencePatternType.Daily,
Interval = 2
},
Range = new RecurrenceRange()
{
Type = RecurrenceRangeType.EndDate,
EndDate = DateTimeOffset.Parse("2024-2-5T12:00:00+08:00")
}
Type = RecurrencePatternType.Daily,
Interval = 2
},
Range = new RecurrenceRange()
{
Type = RecurrenceRangeType.EndDate,
EndDate = DateTimeOffset.Parse("2024-2-5T12:00:00+08:00")
}
}
};

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-2T23:00:00+08:00");
var context = new FeatureFilterEvaluationContext()
{
Settings = settings
};

DateTimeOffset? closestStart;
Assert.False(cache.TryGetValue(settings, out closestStart));

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-2T23:00:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-3T00:00:00+08:00"), closestStart);

for (int i = 0; i < 12; i++)
{
mockedTimeProvider.UtcNow = mockedTimeProvider.UtcNow.AddHours(1);
Assert.True(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-3T00:00:00+08:00"), closestStart);
}

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-3T11:59:59+08:00");
Assert.True(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-3T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-3T12:00:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-5T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-5T00:00:00+08:00");
Assert.True(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-5T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-5T12:00:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Null(closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-7T00:00:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Null(closestStart);

for (int i = 0; i < 10; i++ )
{
mockedTimeProvider.UtcNow = mockedTimeProvider.UtcNow.AddDays(1);
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Null(closestStart);
}

context = new FeatureFilterEvaluationContext()
settings = new TimeWindowFilterSettings()
{
Settings = new TimeWindowFilterSettings()
Start = DateTimeOffset.Parse("2024-2-1T00:00:00+08:00"), // Thursday
End = DateTimeOffset.Parse("2024-2-1T12:00:00+08:00"),
Recurrence = new Recurrence()
{
Start = DateTimeOffset.Parse("2024-2-1T00:00:00+08:00"), // Thursday
End = DateTimeOffset.Parse("2024-2-1T12:00:00+08:00"),
Recurrence = new Recurrence()
Pattern = new RecurrencePattern()
{
Pattern = new RecurrencePattern()
{
Type = RecurrencePatternType.Weekly,
// FirstDayOfWeek is Sunday by default.
DaysOfWeek = new List<DayOfWeek>() { DayOfWeek.Thursday, DayOfWeek.Sunday }
},
Range = new RecurrenceRange()
{
Type = RecurrenceRangeType.Numbered,
NumberOfOccurrences = 2
}
Type = RecurrencePatternType.Weekly,
// FirstDayOfWeek is Sunday by default.
DaysOfWeek = new List<DayOfWeek>() { DayOfWeek.Thursday, DayOfWeek.Sunday }
},
Range = new RecurrenceRange()
{
Type = RecurrenceRangeType.Numbered,
NumberOfOccurrences = 2
}
}
};

context = new FeatureFilterEvaluationContext()
{
Settings = settings
};

Assert.False(cache.TryGetValue(settings, out closestStart));

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-1-31T23:00:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-1T00:00:00+08:00"), closestStart);

for (int i = 0; i < 12; i++)
{
mockedTimeProvider.UtcNow = mockedTimeProvider.UtcNow.AddHours(1);
Assert.True(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-1T00:00:00+08:00"), closestStart);
}

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-1T11:59:59+08:00");
Assert.True(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-1T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-1T12:00:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-4T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-2T00:00:00+08:00"); // Friday
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-4T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-4T00:00:00+08:00"); // Sunday
Assert.True(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-4T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-4T06:00:00+08:00");
Assert.True(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Equal(DateTimeOffset.Parse("2024-2-4T00:00:00+08:00"), closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-4T12:01:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Null(closestStart);

mockedTimeProvider.UtcNow = DateTimeOffset.Parse("2024-2-8T00:00:00+08:00");
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Null(closestStart);

for (int i = 0; i < 10; i++)
{
mockedTimeProvider.UtcNow = mockedTimeProvider.UtcNow.AddDays(1);
Assert.False(await mockedTimeWindowFilter.EvaluateAsync(context));
Assert.True(cache.TryGetValue(settings, out closestStart));
Assert.Null(closestStart);
}
}
}
Expand Down