Skip to content

Conversation

@zhiyuanliang-ms
Copy link
Member

@zhiyuanliang-ms zhiyuanliang-ms commented Mar 20, 2024

We've already offer <feature> tags which can be used to conditionally render content based on whether a feature is enabled or not.

<feature name="FeatureX">
  <p>This can only be seen if 'FeatureX' is enabled.</p>
</feature>

We want to extend the feature tag helper to support variant.

The usage will be like:

<feature name=”Alpha” variant=”V1”> Content only for Variant 1</feature> 
<feature name=”Alpha” variant=”V2> Content only for Variant 2</feature> 

@zhenlan
Copy link
Member

zhenlan commented Mar 21, 2024

It will be helpful if you can add description and examples of usage.

@zhiyuanliang-ms
Copy link
Member Author

zhiyuanliang-ms commented Apr 7, 2024

README updated.

@zhiyuanliang-ms
Copy link
Member Author

@jimmyca15 @rossgrambo Could you help review/approve this PR?

@zhiyuanliang-ms zhiyuanliang-ms merged commit d9ff1af into preview May 19, 2024
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/variant-tag-helper branch May 19, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants