-
Notifications
You must be signed in to change notification settings - Fork 126
Adds extension methods for TrackEvent and TrackMetric #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
0a42c2c
f9c3064
c76dba5
8560fb9
0168adf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,72 @@ | ||||||
| using Microsoft.ApplicationInsights; | ||||||
| using Microsoft.ApplicationInsights.DataContracts; | ||||||
| using Microsoft.FeatureManagement.FeatureFilters; | ||||||
|
|
||||||
| namespace Microsoft.FeatureManagement.Telemetry.ApplicationInsights | ||||||
| { | ||||||
| /// <summary> | ||||||
| /// Provides extension methods for tracking events with TargetingContext. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
The same suggestion for other occurrences of the word "TargetingContext"
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned in #347 (comment)
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Contextual filters describe an interface that they handle. This allows a single app context type to satisfy multiple contextual feature filters.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. *Removing my comment in favor of Jimmy's ^ |
||||||
| /// </summary> | ||||||
| public static class ApplicationInsightsTelemetryExtensions | ||||||
|
rossgrambo marked this conversation as resolved.
Outdated
|
||||||
| { | ||||||
| /// <summary> | ||||||
| /// Extension method to track an event with TargetingContext. | ||||||
| /// </summary> | ||||||
| public static void TrackEvent(this TelemetryClient telemetryClient, string eventName, TargetingContext targetingContext, IDictionary<string, string> properties = null, IDictionary<string, double> metrics = null) | ||||||
| { | ||||||
| if (properties == null) | ||||||
| { | ||||||
| properties = new Dictionary<string, string>(); | ||||||
| } | ||||||
|
|
||||||
| properties.Add("TargetingId", targetingContext.UserId); | ||||||
|
rossgrambo marked this conversation as resolved.
Outdated
|
||||||
|
|
||||||
| telemetryClient.TrackEvent(eventName, properties, metrics); | ||||||
| } | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// Extension method to track an EventTelemetry with TargetingContext. | ||||||
|
rossgrambo marked this conversation as resolved.
Outdated
|
||||||
| /// </summary> | ||||||
| public static void TrackEvent(this TelemetryClient telemetryClient, EventTelemetry telemetry, TargetingContext targetingContext) | ||||||
| { | ||||||
| if (telemetry == null) | ||||||
|
rossgrambo marked this conversation as resolved.
|
||||||
| { | ||||||
| telemetry = new EventTelemetry(); | ||||||
| } | ||||||
|
|
||||||
| telemetry.Properties["TargetingId"] = targetingContext.UserId; | ||||||
|
rossgrambo marked this conversation as resolved.
|
||||||
|
|
||||||
| telemetryClient.TrackEvent(telemetry); | ||||||
| } | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// Extension method to track a metric with TargetingContext. | ||||||
| /// </summary> | ||||||
| public static void TrackMetric(this TelemetryClient telemetryClient, string name, double value, TargetingContext targetingContext, IDictionary<string, string> properties = null) | ||||||
|
rossgrambo marked this conversation as resolved.
Outdated
|
||||||
| { | ||||||
| if (properties == null) | ||||||
| { | ||||||
| properties = new Dictionary<string, string>(); | ||||||
| } | ||||||
|
|
||||||
| properties.Add("TargetingId", targetingContext.UserId); | ||||||
|
|
||||||
| telemetryClient.TrackMetric(name, value, properties); | ||||||
| } | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// Extension method to track a MetricTelemetry with TargetingContext. | ||||||
|
rossgrambo marked this conversation as resolved.
Outdated
|
||||||
| /// </summary> | ||||||
| public static void TrackMetric(this TelemetryClient telemetryClient, MetricTelemetry telemetry, TargetingContext targetingContext) | ||||||
| { | ||||||
| if (telemetry == null) | ||||||
| { | ||||||
| telemetry = new MetricTelemetry(); | ||||||
| } | ||||||
|
|
||||||
| telemetry.Properties["TargetingId"] = targetingContext.UserId; | ||||||
|
|
||||||
| telemetryClient.TrackMetric(telemetry); | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
Uh oh!
There was an error while loading. Please reload this page.