-
Notifications
You must be signed in to change notification settings - Fork 127
Mention TargetingContext and fix wording in Variants section of readme #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+54
−27
Merged
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8e914b9
mention itargetingcontextaccessor for variant allocation
amerjusupovic b3f1874
update changes
amerjusupovic d429d77
add reference to ITargetingContextAccessor to readme for allocation
amerjusupovic 040277a
Merge branch 'preview' of https://github.com/microsoft/FeatureManagem…
amerjusupovic 3735366
update with new discussed changes, rename sections and introduce cont…
amerjusupovic 26db004
fix wording of default
amerjusupovic 52d7e2b
fix wording to avoid implying variants are assigned per feature
amerjusupovic 3d9e71a
use the term assign when referring to variants returned for a user
amerjusupovic c226638
use assign term in more places
amerjusupovic df3eb50
small changes
amerjusupovic ed32a95
Update README.md
amerjusupovic 90aedf3
update section titles
amerjusupovic 77a93f1
Merge branch 'ajusupovic/update-readme-variants' of https://github.co…
amerjusupovic 15ad38d
resolve comments
amerjusupovic 6097fc5
fix typo
amerjusupovic 95c2f4f
update link to allocating variants section
amerjusupovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.