set black with 120 line length #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
thinkall and
sonichi
and removed request for
thinkall
|
Not sure, but the two failing test does not seem to be related to the formating update... |
|
@Borda Thanks for your PR! Can you figure out how to address the conflicts? |
Sure, it shall be trivial as the main contribution of this PR is update config, the rest is just bot work, so I will accept all changes from main branch and re-run the bot 🐰 |
|
@skzhang1 shall be fixed now 🐿️ |
skzhang1
approved these changes
Apr 10, 2023
yiranwu0
approved these changes
Apr 10, 2023
thinkall
pushed a commit
to thinkall/FLAML
that referenced
this pull request
May 30, 2023
Related work items: microsoft#493, microsoft#777, microsoft#820, microsoft#837, microsoft#843, microsoft#848, microsoft#849, microsoft#850, microsoft#853, microsoft#855, microsoft#857, microsoft#869, microsoft#870, microsoft#888, microsoft#894, microsoft#923, microsoft#924, microsoft#925, microsoft#934, microsoft#952, microsoft#962, microsoft#973, microsoft#975, microsoft#995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
as Flake8 is set already to 127 line length Black has default 88 so it is natural to have both aligned, see flake8 setting:
FLAML/.flake8
Line 3 in f404b66
Related issue number
Checks