Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable tft logger #836

Closed
wants to merge 1 commit into from
Closed

disable tft logger #836

wants to merge 1 commit into from

Conversation

int-chaos
Copy link
Collaborator

#833 did not fix issue. new attempt to disable logger by adding set log_interval=0 when log=False

sonichi
sonichi reviewed Dec 4, 2022
View reviewed changes
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is early_stop_callback invalid when log=False?

@sonichi
Copy link
Contributor

sonichi commented Dec 4, 2022

Why don't we disable logging until the issue in pytorch-forecasting is fixed?

@sonichi
Copy link
Contributor

sonichi commented Dec 6, 2022

Why don't we disable logging until the issue in pytorch-forecasting is fixed?

I did that in #837

@int-chaos
Copy link
Collaborator Author

Why don't we disable logging until the issue in pytorch-forecasting is fixed?

I did that in #837

sounds good, will close PR

@int-chaos int-chaos closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonichi sonichi sonichi approved these changes

@EgorKraevTransferwise EgorKraevTransferwise Awaiting requested review from EgorKraevTransferwise

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

@markharley markharley Awaiting requested review from markharley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@int-chaos @sonichi