Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add support for sklearn HistGradientBoostingEstimator #1230

Merged
merged 13 commits into from
Oct 31, 2023
Merged

[ENH] Add support for sklearn HistGradientBoostingEstimator #1230

merged 13 commits into from
Oct 31, 2023

Conversation

glevv
Copy link
Contributor

@glevv glevv commented Sep 27, 2023 •
edited
Loading

Why are these changes needed?

This PR Adds support for HistGradientBoosting estimator

Related issue number

Closes #868

Checks

@glevv
Copy link
Contributor Author

glevv commented Sep 28, 2023

@microsoft-github-policy-service agree

@glevv
Copy link
Contributor Author

glevv commented Sep 29, 2023

pre-commit hook made a lot of unnecessary changes

@glevv glevv marked this pull request as ready for review October 15, 2023 13:24
@sonichi sonichi added the enhancement New feature or request label Oct 15, 2023
@glevv
Copy link
Contributor Author

glevv commented Oct 16, 2023

Not sure about how should I fix this empty dataframe error

@sonichi
Copy link
Contributor

sonichi commented Oct 16, 2023

It doesn't look to be caused by you PR. @int-chaos do you know why the forecast test fails?

@glevv glevv changed the title HistGradientBoosting support [ENH] Add support for sklearn HistGradientBoostingEstimator Oct 19, 2023
@sonichi
Copy link
Contributor

sonichi commented Oct 21, 2023

The test passed. @qingyun-wu could you review or find other reviewers?

thinkall
thinkall reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @glevv for the contribution, nice PR!

flaml/automl/model.py Show resolved Hide resolved
@sonichi sonichi requested a review from Borda October 24, 2023 15:51
@sonichi sonichi added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@sonichi sonichi added this pull request to the merge queue Oct 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2023
@thinkall thinkall added this pull request to the merge queue Oct 31, 2023
Merged via the queue into microsoft:main with commit 6b93c2e Oct 31, 2023
13 checks passed
@glevv glevv deleted the sklearn-hgb branch November 1, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkall thinkall thinkall approved these changes

@sonichi sonichi sonichi approved these changes

@EgorKraevTransferwise EgorKraevTransferwise Awaiting requested review from EgorKraevTransferwise

@markharley markharley Awaiting requested review from markharley

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

@int-chaos int-chaos Awaiting requested review from int-chaos

@skzhang1 skzhang1 Awaiting requested review from skzhang1

@Borda Borda Awaiting requested review from Borda

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HistGradientBoosting support
3 participants
@glevv @sonichi @thinkall