Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent; code_execution_config; exit; version #1179

Merged
merged 16 commits into from
Aug 14, 2023
Merged

silent; code_execution_config; exit; version #1179

merged 16 commits into from
Aug 14, 2023

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Aug 11, 2023

Why are these changes needed?

  1. Support silent mode to hide unnecessary messages in chess and group chat. (experimental)
  2. Support lookback for multiple messages in code_execution_config. (experimental) @LittleLittleCloud
  3. Improve group chat speaker selection. @LittleLittleCloud
  4. Support exit group chat when human input is "exit".
  5. Bump version to 2.0.0.

Related issue number

Checks

@sonichi sonichi temporarily deployed to openai August 11, 2023 01:56 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 11, 2023 04:00 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 11, 2023 04:00 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 11, 2023 13:04 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 11, 2023 13:04 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 11, 2023 21:28 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 11, 2023 21:28 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 12, 2023 01:21 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 12, 2023 01:21 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 13, 2023 18:41 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 13, 2023 18:41 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 13, 2023 18:41 — with GitHub Actions Inactive
@sonichi
Copy link
Contributor Author

sonichi commented Aug 13, 2023

Did you compile and check if the doc pages on the website are good? If so, LGTM.

Partially. I made more changes when I checked. But it'll be good to have a second eye on it.

@thinkall

This comment was marked as resolved.

thinkall

This comment was marked as resolved.

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed errors in retrieve chat. One more thing is that there is a function _generate_math_reply in math_user_proxy_agent.py, but I don't see it being called when running autogen_agentchat_MathChat.ipynb. If it will be called, looks like it should be updated to handle parameter config.

@sonichi
Copy link
Contributor Author

sonichi commented Aug 14, 2023

I've fixed errors in retrieve chat. One more thing is that there is a function _generate_math_reply in math_user_proxy_agent.py, but I don't see it being called when running autogen_agentchat_MathChat.ipynb. If it will be called, looks like it should be updated to handle parameter config.

Thanks. I fixed that.

@sonichi sonichi temporarily deployed to openai August 14, 2023 05:07 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 14, 2023 05:07 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai August 14, 2023 05:07 — with GitHub Actions Inactive
@thinkall thinkall added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 7ab4d11 Aug 14, 2023
16 checks passed
@sonichi sonichi deleted the silent branch August 14, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants