-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support async in agents #1178
Merged
support async in agents #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonichi
requested review from
yiranwu0,
ekzhu,
qingyun-wu,
gagb,
skzhang1 and
thinkall
August 7, 2023 01:49
qingyun-wu
reviewed
Aug 7, 2023
ekzhu
requested changes
Aug 7, 2023
ekzhu
approved these changes
Aug 7, 2023
As the next step after this PR, maybe we can think about the design of the message stream to manage async agent tasks. |
qingyun-wu
approved these changes
Aug 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Big thanks to @qingyun-wu for her previous hard work and exploration in this idea. Also thanks to @gagb @ekzhu @skzhang1 for their inspiration.
Related issue number
This PR depends on #1177
Related to: #1063 #1098
Checks