Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify auto_reply; bug fix in UserProxyAgent; reorg agent hierarchy #1142

Merged
merged 68 commits into from
Jul 26, 2023
Merged

unify auto_reply; bug fix in UserProxyAgent; reorg agent hierarchy #1142

merged 68 commits into from
Jul 26, 2023

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Jul 23, 2023 •
edited
Loading

Why are these changes needed?

  1. Make auto_reply() a common method for all agents for convenience.
  2. Fix a bug in UserProxyAgent to pass config to the constructor of parent class.
  3. Documentation update. Use absolute path in documentation markdown.
  4. Clean agent hierarchy: Agent -> GenericAgent -> (AssistantAgent, UserProxyAgent)

Related issue number

Checks

@sonichi sonichi temporarily deployed to openai July 25, 2023 14:18 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai July 25, 2023 14:18 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai July 25, 2023 14:18 — with GitHub Actions Inactive
@sonichi sonichi enabled auto-merge July 25, 2023 18:05
@sonichi sonichi added this pull request to the merge queue Jul 25, 2023
@sonichi sonichi removed this pull request from the merge queue due to a manual request Jul 25, 2023
@sonichi sonichi enabled auto-merge July 25, 2023 21:35
@qingyun-wu qingyun-wu requested a review from LeoLjl July 25, 2023 22:26
@sonichi sonichi added this pull request to the merge queue Jul 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2023
@sonichi sonichi added this pull request to the merge queue Jul 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2023
@sonichi sonichi added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit 3e7aac6 Jul 26, 2023
13 of 16 checks passed
@sonichi sonichi deleted the reply branch July 26, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JieyuZ2 JieyuZ2 JieyuZ2 approved these changes

@yiranwu0 yiranwu0 yiranwu0 approved these changes

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

@thinkall thinkall Awaiting requested review from thinkall

@gagb gagb Awaiting requested review from gagb

@LeoLjl LeoLjl Awaiting requested review from LeoLjl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonichi @JieyuZ2 @yiranwu0