Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log metric #1125

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Add log metric #1125

merged 3 commits into from
Jul 13, 2023

Conversation

thinkall
Copy link
Collaborator

Why are these changes needed?

To log metric as discussed in the discord message

Hi <@1022910063620390932> quick question. I noticed that when I set a metric to optimize for, flaml doesn't log that metric to mlflow (when I start an mlflow run I'm the flaml context). It seems like flaml always logs "best_validation_loss" - I think it's 1-metric (when the metric is "bigger=better").

Is there a way to get flaml to log the optimization metric with the correct name?

Related issue number

Checks

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sonichi sonichi added this pull request to the merge queue Jul 13, 2023
Merged via the queue into microsoft:main with commit 8ac9a39 Jul 13, 2023
@thinkall thinkall deleted the add_log_metric branch July 24, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants