Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clear DateTime Field (Solve Issue #745) #749

Merged
merged 16 commits into from
Feb 7, 2020
Merged

Fix Clear DateTime Field (Solve Issue #745) #749

merged 16 commits into from
Feb 7, 2020

Conversation

AngelRodriguez8008
Copy link
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (updates to documentation, formatting, etc.)

Description

Some changes in UI causes that when date field is selected the calendar flyout will show & clear the value in like "Keys.Control + "a" => Backspace" do not work properly. A new overload for SetValue
& ClearValue for DateTimeControl was created.

Issues addressed

#745

All submissions:

  • My code follows the code style of this project.
  • Do existing samples that are effected by this change still run?
  • I have added samples for new functionality.
  • I raise detailed error messages when possible.
  • My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

  • Chrome
  • Firefox
  • IE
  • Edge

@AngelRodriguez8008 AngelRodriguez8008 changed the title Fix Clear DateTime Field (Issue #745) Fix Clear DateTime Field (Solve Issue #745) Feb 5, 2020
@AngelRodriguez8008 AngelRodriguez8008 mentioned this pull request Feb 5, 2020
Closed
@AngelRodriguez8008
Copy link
Contributor Author

Tests UCITestCreateActivity_ClearHeaderDateTimes will be solve after merge with #747

@mVermaat mVermaat mentioned this pull request Feb 6, 2020
Closed
@TYLEROL TYLEROL mentioned this pull request Feb 6, 2020
Merged
12 tasks
@AngelRodriguez8008
Merge branch 'develop' into users/angel/fixSetHeaderValues
ee3ba4b 
# Conflicts:
#	Microsoft.Dynamics365.UIAutomation.Api.UCI/WebClient.cs
#	Microsoft.Dynamics365.UIAutomation.Browser/Extensions/SeleniumExtensions.cs
#	Microsoft.Dynamics365.UIAutomation.Sample/UCI/Create/CreateActivity.cs
@AngelRodriguez8008
Merge branch 'develop' into users/angel/fixSetHeaderValues
2a45707
@AngelRodriguez8008
Add MfaSecrectKey to app.build.config
bfc3dc7
@AngelRodriguez8008
Restore ClickIfVisible
b7bcd16
@AngelRodriguez8008
Roll back OpenRecord Logic -> DoubleClick fail on this cell
6307a5c
@AngelRodriguez8008
Merge branch 'users/angel/fixSetHeaderValues' into users/angel/fixSet…
c412254 
…DateTimeValue

# Conflicts:
#	Microsoft.Dynamics365.UIAutomation.Api.UCI/WebClient.cs
@AngelRodriguez8008
Merge branch 'users/angel/fixSetHeaderValues' into users/angel/fixSet…
89fd125 
…DateTimeValue
@AngelRodriguez8008
Copy link
Contributor Author

Can be merged!

@TYLEROL TYLEROL merged commit f7cb7d7 into microsoft:develop Feb 7, 2020
@TYLEROL TYLEROL added this to the 9.1.0.12013 milestone Feb 7, 2020
@TYLEROL TYLEROL linked an issue Feb 7, 2020 that may be closed by this pull request
ClearValue for date field #745
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TYLEROL TYLEROL TYLEROL approved these changes

@dtu11 dtu11 Awaiting requested review from dtu11

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
9.1.0.12013
Development

Successfully merging this pull request may close these issues.

ClearValue for date field
2 participants
@AngelRodriguez8008 @TYLEROL