[SPIRV] Fix layout rule for BufferPointer pointee type #7956
+31
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When picking the layout rule for the Pointee type of a BufferPointer, we are using the layout for the object containing the pointer, but that is incorrect. The layout for the PhysicalStorageBuffer should always follow the storage buffer layout rules. Fixes microsoft#7893
Keenuts
approved these changes
Dec 1, 2025
Collaborator
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
LGTM, minus the SPIRV-Headers/tools change. Might be a mistake?
Keenuts
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When picking the layout rule for the Pointee type of a BufferPointer, we
are using the layout for the object containing the pointer, but that is
incorrect.
The layout for the PhysicalStorageBuffer should always follow the
storage buffer layout rules.
Fixes #7893