[SPIRV] Fix declaration order of values in decorations#7672
Merged
s-perron merged 1 commit intomicrosoft:mainfrom Jul 29, 2025
Merged
[SPIRV] Fix declaration order of values in decorations#7672s-perron merged 1 commit intomicrosoft:mainfrom
s-perron merged 1 commit intomicrosoft:mainfrom
Conversation
The value that decorates another value, but be declared before the value it decorates. See KhronosGroup/SPIRV-Tools#6227.
Keenuts
reviewed
Jul 29, 2025
|
|
||
| // Output the decorations for the type first. This will create other values | ||
| // that are on the decorations, and they must appear before the type. | ||
| emitDecorationsForNodePayloadArrayTypes(npaType, id); |
Collaborator
There was a problem hiding this comment.
I suppose this was moved for the same reason? But no test change seem related to the node payload?
Collaborator
Author
There was a problem hiding this comment.
Yes it is. Some tests failed validation with the latest spirv-tools without this. This change will be tested once we update spirv-tools. I want it to be a separate change in case there is a regression. It will be easier to identify what caused the change.
Keenuts
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value that decorates another value must be declared before the value
it decorates. See KhronosGroup/SPIRV-Tools#6227.