[SPIRV] Use OpCopyLogical to reconstruct values #7530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DXC needs to change the layout of a value, it currently has to extract each individual scalar, and then reconstruct using the type with the different layout. If you have a large array or struct with many member, this generates a lot of extra code. Starting in SPIR-V 1.4, the OpCopyLogical instruction is available to do the reconstruction. This should help generate less code, which will lead to improved compile time and maybe smaller binary sizes. Fixes microsoft#7493
Keenuts
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DXC needs to change the layout of a value, it currently has to
extract each individual scalar, and then reconstruct using the type with
the different layout.
If you have a large array or struct with many member, this generates a
lot of extra code.
Starting in SPIR-V 1.4, the OpCopyLogical instruction is available to do
the reconstruction.
This should help generate less code, which will lead to improved compile
time and maybe smaller binary sizes.
Fixes #7493