Add dtslint/dts-critic to the monorepo #353

sandersn · 2021-11-29T22:52:21Z

For both dtslint and dts-critic, lerna import --flatten
Update package.json names to add @definitelytyped/
Switch from depending on tsutils to TS internals for detecting JSDoc -- removes a conflicting dependency on two versions of typescript.
Remove redundant lint dependencies and update code to match new lint rules. Also make the naming-convention rule smarter.
Update README with links to original repos.

The last four commits are the only new ones.

* Fix banned words check and update dts-critic 1. Update to dts-critic 1.2, which no longer requires project urls to include the homepage url specified on npm. 2. Check for banned words for all packages, not just those complex enough to have a package.json. The location of the check was wrong. * Remove handling for project url mismatch from npm-naming * 0.7.7: Fix banned-words check and update dts-critic

previously it was any substring.

I didn't add a test because tslint doesn't support baselines with newlines in them. It works locally, though.

Not all type definitions use `React.createElement` as the jsx pragma. I bumped into this issue when updating `storybook__preact` types as per DefinitelyTyped/DefinitelyTyped#37275 By adding the compiler option `jsxFactory` other pragmas can be used in type definitions

* Add documentation about localTs and expectOnly option * Update `--expectOnly` description According to microsoft/dtslint#244 (comment) Co-Authored-By: Nathan Shively-Sanders <[email protected]>

@lukyth

Thanks to @IvonGoncharov and @lukyth, respectively.

This is important for users that always use --localTs, which means that they never run the code that creates the cache directory as part of installing old versions of typescript.

Check stderr when stdout is empty

To the version that supports TS 4.5.

1. Update some TS usage. 2. Depend on TS internals instead of tsutils for JSDoc. 3. Update name of dtsutil/dts-critic imports.

Also improve regex for "No interfaces starting with I" so that it no longer forbids I followed by a lowercase letter.

packages/dts-critic/.github/workflows/nodejs.yml

.eslintrc.json

packages/dtslint/package.json

andrewbranch · 2021-11-30T20:59:11Z

packages/dtslint/package.json

@@ -17,14 +17,13 @@
  ],
  "repository": {
    "type": "git",
-    "url": "https://github.com/Microsoft/dtslint.git"
+    "url": "https://github.com/microsoft/DefinitelyTyped-tools.git"
  },
  "scripts": {
    "watch": "tsc --watch",
    "build": "tsc",
    "lint": "eslint --ext ts src",
    "test": "npm run build && node test/test.js",


Trailing comma killed it

andrewbranch

I'm excited this is done 🌟 Thanks!

sandersn · 2021-12-01T00:13:51Z

I'll ship this tomorrow morning when I can watch for problems.

sandersn and others added 30 commits November 29, 2021 12:08

0.6.2 - update dependencies

bd03d10

0.7.0 - log performance data to disk

f3eed4b

Fix lint x(

84d66a7

0.7.1 - Update dependencies

3f2fe43

0.7.2 - Update dts-critic dependency

b361b11

0.7.3 - update dts-critic dependency

cd4d8b6

Resolve localTs path (#229)

fb3363c

0.7.4 - call path.resolve on tsLocal path

d772f24

0.7.5 - support TS 3.6

c771a74

0.7.6 roll back to definitelytyped-header-parser 1.1

2096b15

0.7.7 - support TS 3.6 again

85addbd

Actually change to 0.7.7

2df1c31

forbid only whole-word 'download'

8f47d82

previously it was any substring.

0.7.9 - fix forbidden-word regex for 'download'

7b37393

Show TS version in ExpectType error (#237)

099d746

I didn't add a test because tslint doesn't support baselines with newlines in them. It works locally, though.

0.8.0: Add TS version to ExpectType errors

4592a43

Add CODEOWNERS so PRs ping me

c9574c4

0.9 - npm-naming:require d.ts to match npm version

a491db6

0.9.1 - Update @types/node dependency; allow jsxFactory

31a61e8

Add documentation about localTs and expectOnly option (#244)

cf5d562

* Add documentation about localTs and expectOnly option * Update `--expectOnly` description According to microsoft/dtslint#244 (comment) Co-Authored-By: Nathan Shively-Sanders <[email protected]>

Remove long series of empty lines in tool output (#247)

d8126c4

0.9.2 - remove bogus newlines+better documentation

e425d77

Thanks to @IvonGoncharov and @lukyth, respectively.

Use prepublishOnly instead of made-up do-publish

eb31507

ExpectRule creates cache dir (#248)

b3a7f68

This is important for users that always use --localTs, which means that they never run the code that creates the cache directory as part of installing old versions of typescript.

0.9.4 - stop crashing after an initial --localTs run

683a0f5

0.9.4 - Add TS3.7 support

d737c04

dt-header-parser 3.7.1

38f9da4

0.9.5 - definitelytyped-header-parser 3.7.1

c853fc2

sandersn added 16 commits November 29, 2021 12:13

3.3.2 - update @definitelytyped/header-parser dependency

738bd07

3.3.3 - update @definitelytyped/header-parser for 4.2

e784145

3.3.4 - update @definitelytyped/header-parser for shipping 4.1

e4ae60d

Merge pull request #42 from DefinitelyTyped/check-stderr-too

d10809a

Check stderr when stdout is empty

3.3.5 - work correctly with npm@7

73991be

3.3.6 - fix for npm pack on npm@7

d2b2df3

Update to latest header-parser

3e361e9

3.3.8 - update to latest header-parser

d2046e4

3.3.9 - update @definitelytyped/header-parser dependency

4808814

true 3.3.9 - update @definitelytyped/header-parser

5625a41

To the version that supports TS 4.5.

3.3.10 - update @definitelytyped/header-parser

b00ba3b

3.3.11 -- update @definitelytyped/header-parser dependency

9de4de8

Add dtslint and dts-critic to README

c5a2d49

Alter package.jsons and run 'yarn install'

83d26c7

Post-package-import updates

1680a86

1. Update some TS usage. 2. Depend on TS internals instead of tsutils for JSDoc. 3. Update name of dtsutil/dts-critic imports.

Fix lint

39b82d1

Also improve regex for "No interfaces starting with I" so that it no longer forbids I followed by a lowercase letter.

sandersn marked this pull request as ready for review November 30, 2021 18:50

sandersn requested review from andrewbranch and orta as code owners November 30, 2021 18:50

andrewbranch reviewed Nov 30, 2021

View reviewed changes

packages/dts-critic/.github/workflows/nodejs.yml Outdated Show resolved Hide resolved

.eslintrc.json Show resolved Hide resolved

packages/dtslint/package.json Outdated Show resolved Hide resolved

packages/dtslint/package.json Outdated Show resolved Hide resolved

Address PR comments

5fea674

andrewbranch reviewed Nov 30, 2021

View reviewed changes

sandersn added 4 commits November 30, 2021 13:11

remove trailing comma from dtslint/package.json

142a9f9

Merge branch 'master' into add-dtslint/critic

d8280db

update versions in new package.json

5190805

fix internal dependency versions

2320850

andrewbranch approved these changes Dec 1, 2021

View reviewed changes

sandersn merged commit dae5c76 into master Dec 1, 2021

sandersn deleted the add-dtslint/critic branch December 1, 2021 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dtslint/dts-critic to the monorepo #353

Add dtslint/dts-critic to the monorepo #353

sandersn commented Nov 29, 2021 •

edited

Loading

andrewbranch Nov 30, 2021

andrewbranch left a comment

sandersn commented Dec 1, 2021

Add dtslint/dts-critic to the monorepo #353

Add dtslint/dts-critic to the monorepo #353

Conversation

sandersn commented Nov 29, 2021 • edited Loading

andrewbranch Nov 30, 2021

Choose a reason for hiding this comment

andrewbranch left a comment

Choose a reason for hiding this comment

sandersn commented Dec 1, 2021

sandersn commented Nov 29, 2021 •

edited

Loading