Simplify decimal conversions #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
reviewed
Oct 28, 2025
Member
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
The simplification looks good. But it doesn't actually deliver the main theme of #1455, which is as its title says: "Implement decimal to DECIMAL conversion"
This merely re-implements the functionality that was already there.
Can you add an implicit conversion operator from decimal to DECIMAL?
Member
Author
|
There is such a conversion operator but it was |
AArnott
approved these changes
Oct 28, 2025
This was referenced Oct 29, 2025
Bump Microsoft.Windows.CsWin32 from 0.3.213 to 0.3.236
progressonderwijs/ProgressOnderwijsUtils#1196
Closed
craigktreasure
pushed a commit
to craigktreasure/StartMenuCleaner
that referenced
this pull request
Nov 1, 2025
Updated [Microsoft.Windows.CsWin32](https://github.com/microsoft/CsWin32) from 0.3.228 to 0.3.238. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Windows.CsWin32's releases](https://github.com/microsoft/CsWin32/releases)._ ## 0.3.238 ## Changes: * #1520: Don't make void* params Span<byte> in friendly methods * #1517: CsWin32Generator should allow newer language versions This list of changes was [auto generated](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12697392&view=logs). ## 0.3.236 NOTE: This changes the signature of methods with optional parameters. This change is also documented at https://microsoft.github.io/CsWin32/docs/getting-started.html: ### Optional out/ref parameters Some parameters in win32 are `[optional, out]` or `[optional, in, out]`. C# does not have an idiomatic way to represent this concept, so for any method that has such parameters, CsWin32 will generate two versions: one with all `ref` or `out` parameters included, and one with all such parameters omitted. For example: ```c# // Omitting the optional parameter: IsTextUnicode(buffer); // Passing ref for optional parameter: IS_TEXT_UNICODE_RESULT result = default; IsTextUnicode(buffer, ref result); ``` ### Working with Span-typed and MemorySize-d parameters In the Win32 APIs there are many functions where one parameter is a buffer (`void*` or `byte*`) and another parameter is the size of that buffer. When generating for a target framework that supports Spans, there will be overloads of these functions that take a `Span<byte>` which represents both of these parameters, since a Span refers to a chunk of memory and a length. For example, an API like [IsTextUnicode](https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-istextunicode) has a `void*` parameter whose length is described by the iSize parameter in the native signature. The CsWin32 projection of this method will be: ```c# BOOL IsTextUnicode(ReadOnlySpan<byte> lpv, ref IS_TEXT_UNICODE_RESULT lpiResult) ``` Instead of passing the buffer and length separately, in this projection you pass just one parameter. Span is a flexible type with many things that can be converted to it safely. You will also see Span parameters for things that may look like a struct but are variable sized. For example, [InitializeAcl](https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-initializeacl) looks like it returns an ACL struct but the parameter is annotated with a `[MemorySize]` attribute in the metadata, indicating it is variable-sized based on another parameter. Thus, the cswin32 projection of this method will project this parameter as a `Span<byte>` since the size of the parameter is variable: ```c# // The cswin32 signature: static BOOL InitializeAcl(Span<byte> pAcl, ACE_REVISION dwAclRevision) { ... } ``` And you would call this by creating a buffer to receive the ACL. Then, after the call you can reinterpret the buffer as an ACL: ```c# // Make a buffer Span<byte> buffer = new byte[CalculateAclSize(...)]; InitializeAcl(buffer, ACE_REVISION.ACL_REVISION); // The beginning of the buffer is an ACL, so cast it to a ref: ref ACL acl = ref MemoryMarshal.AsRef<ACL>(buffer); // Or treat it as a Span: Span<ACL> aclSpan = MemoryMarshal.Cast<byte, ACL>(buffer); ``` CsWin32 will also generate a struct-typed parameter for convenience but this overload will pass `sizeof(T)` for the length parameter to the underlying Win32 API, so this only makes sense in some overloads such as [SHGetFileInfo](https://learn.microsoft.com/windows/win32/api/shellapi/nf-shellapi-shgetfileinfow) where the parameter has an annotation indicating it's variable-sized, but the size is only ever `sizeof(SHFILEINFOW)`: ```c# // Span<byte> overload: static nuint SHGetFileInfo(string pszPath, FILE_FLAGS_AND_ATTRIBUTES dwFileAttributes, Span<byte> psfi, SHGFI_FLAGS uFlags) // ref SHGETFILEINFOW overload: static nuint SHGetFileInfo(string pszPath, FILE_FLAGS_AND_ATTRIBUTES dwFileAttributes, ref SHFILEINFOW psfi, SHGFI_FLAGS uFlags) ... (truncated) ## 0.3.235 ## What's Changed * Handle CoCreateable classes in ComSourceGenerators mode by @jevansaks in microsoft/CsWin32#1502 * Simplify decimal conversions by @jevansaks in microsoft/CsWin32#1512 * Prevent SafeHandle from being re-generated in downstream assembly by @jevansaks in microsoft/CsWin32#1514 * Fix ArithmeticOverflow in HANDLE types and other helpers when CheckForOverflowUnderflow is enabled by @jevansaks in microsoft/CsWin32#1513 **Full Changelog**: microsoft/CsWin32@v0.3.228...v0.3.235 Commits viewable in [compare view](microsoft/CsWin32@v0.3.228...v0.3.238). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestion in #1455. Tests already existed to exercise decimal conversions and they still pass.
Fixes #1455.