Delete manual Batch pools regardless of presence of identity, and add more logging #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattMcL4475
changed the title
BMurri
approved these changes
Oct 26, 2022
|
/azp |
…CromwellOnAzure into mattmcl4475/aksTest02
MattMcL4475
force-pushed
the
mattmcl4475/aksTest02
branch
from
c0102c3
to
1121878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new AKS implementation, a manual batch pool may be used if a global identity is included. In this case, the TES task will not have a
workflow_execution_identitybut it will still need to be deleted since it's a manual pool. It's not expected that this should cause issues with AutoPools (since the pool is deleted only if it exists and notdeleting); it could simply result in the AutoPool being deleted sooner. The code handles a potential race condition for deleting as well.