Misc aks followup #507
Merged
Misc aks followup #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsaun
commented
Oct 10, 2022
•
jsaun
commented
- Remove blob storage mounts for Tes.
- Fixes to arguments validation, don't validate helm install if manualhelminstall flag is used and default provisionpostgresql to true if AKS is used.
- Remove settings-system & settings-user, use aksValues.yaml to store all settings.
MattMcL4475
reviewed
Oct 15, 2022
|
|
||
| public async Task UpgradeValuesYaml(IStorageAccount storageAccount, Dictionary<string, string> settings) | ||
| { | ||
| var values = KubernetesYaml.Deserialize<HelmValues>(await Deployer.DownloadTextFromStorageAccountAsync(storageAccount, Deployer.ConfigurationContainerName, "aksValues.yaml", cts)); |
There was a problem hiding this comment.
This is called "aksValues.yml" but below is "values.yaml" - is there a reason for them to differ?
There was a problem hiding this comment.
For the actual helm deployment, it must be named exactly values.yaml. I added the AKS prefix while in the storage account since you mentioned in the meeting last week, and it does add some specificity to the filename in that context.
MattMcL4475
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.