Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CANCELING state to TES #494

Closed

Conversation

MattMcL4475
Copy link
Contributor

Please see proposal here: ga4gh/task-execution-schemas#189

@MattMcL4475 MattMcL4475 marked this pull request as draft September 30, 2022 21:29
@MattMcL4475 MattMcL4475 changed the title Add Cancellation Requested state to TES Add CANCELING state to TES Oct 3, 2022
@tonybendis
Copy link
Contributor

What does the current version of Cromwell do when it sees CANCELING instead of CANCELED state after sending cancelation to TES?

@vsmalladi
Copy link
Contributor

@MattMcL4475 does this have to be refactored and moved to tes repo?

@MattMcL4475
Copy link
Contributor Author

@vsmalladi yes, and also need to have Cromwell implement it and/or test what effect it has on Cromwell, since it won't understand this state. thanks for the ping, I'll ask the Cromwell team about this.

@BMurri
Copy link
Collaborator

BMurri commented Apr 26, 2023

What does the current version of Cromwell do when it sees CANCELING instead of CANCELED state after sending cancelation to TES?

@MattMcL4475 Currently, it treats it as if it were "running"

@BMurri BMurri added the Needs Issue PR needs at least one associated issue label Jul 19, 2023
@BMurri
Copy link
Collaborator

BMurri commented Aug 28, 2024

Included in microsoft/ga4gh-tes#442

@BMurri BMurri closed this Aug 28, 2024
@BMurri BMurri deleted the mattmcl4475/AddCancellationRequestedTesState branch August 28, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Issue PR needs at least one associated issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants